feat(core)!: use new SlickGrid ESM version #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use new SlickGrid ESM build - all Cypress E2E tests are now passing - all Jest unit tests are now passing
ghiscoding
changed the title
- fix an issue where copying and pasting to multiple area only kept the last undo and reapplied it over and over and the cause was because the clipCommand was global to the class so it only kept the last undo, the fix is to make sure the clipCommand variable is local to the execution handler instead
Codecov Report
@@ Coverage Diff @@
## next #1070 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 245 245
Lines 16842 16883 +41
Branches 6044 6056 +12
=========================================
+ Hits 16842 16883 +41
|
ghiscoding
changed the title
ghiscoding
added a commit
that referenced
this pull request
Nov 15, 2023
* feat(core)!: use new SlickGrid ESM version - use new SlickGrid ESM build - all Cypress E2E tests are now passing - all Jest unit tests are now passing
ghiscoding
added a commit
that referenced
this pull request
Nov 18, 2023
* feat(core)!: use new SlickGrid ESM version (#1070) * feat(core)!: move SlickGrid core files directly into the project - drop `slickgrid` npm dependency and instead move all files into the project - the end goal is to have less depencies but also to get rid of unused code like the SlickGrid AutoSize since we have our own code in our ResizerService, this will hopefully make the build smaller as well. There are other duplicate code elsewhere, so moving the code in the project should help simplify the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE⚠️
TODOs