Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: move SlickGrid core files directly into the project #1135

Merged
merged 21 commits into from
Nov 18, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 15, 2023

  • drop slickgrid npm dependency and instead move all files core into the project (mostly because SlickGrid 5.0 is now written in TypeScript, so it is now easier to move into our project and drop external dependency)
  • the end goal is to have less depencies but also to get rid of unused code like the SlickGrid AutoSize since we have our own code in our ResizerService, this will hopefully make the build smaller as well. There are other duplicate code elsewhere, so moving the code in the project should help simplify the code and also make it easier to troubleshoot code
  • the only downside is that SlickGrid core project never had any unit tests written, so that will decrease the test coverage by quite a lot since none of the core files have tests
  • ⚠️ this is a breaking change PR

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 1114 lines in your changes are missing coverage. Please review.

Comparison is base (7d8b6f8) 100.00% compared to head (0ca5390) 78.87%.

Files Patch % Lines
packages/common/src/core/slickDataview.ts 0.39% 784 Missing ⚠️
packages/common/src/core/slickCore.ts 39.66% 210 Missing ⚠️
packages/common/src/core/slickInteractions.ts 3.23% 120 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              next    #1135       +/-   ##
============================================
- Coverage   100.00%   78.87%   -21.13%     
============================================
  Files          245      250        +5     
  Lines        17271    22176     +4905     
  Branches      6244     7755     +1511     
============================================
+ Hits         17271    17488      +217     
- Misses           0     4688     +4688     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* feat(core)!: use new SlickGrid ESM version
- use new SlickGrid ESM build
- all Cypress E2E tests are now passing
- all Jest unit tests are now passing
* chore: test with latest SlickGrid 5.1.0
- drop `slickgrid` npm dependency and instead move all files into the project
- the end goal is to have less depencies but also to get rid of unused code like the SlickGrid AutoSize since we have our own code in our ResizerService, this will hopefully make the build smaller as well. There are other duplicate code elsewhere, so moving the code in the project should help simplify the code
@ghiscoding ghiscoding force-pushed the feat/move-slickgrid-core-to-internal branch from 94f65de to f0196c8 Compare November 15, 2023 06:05
@ghiscoding ghiscoding changed the base branch from next to next2 November 15, 2023 06:33
@ghiscoding ghiscoding marked this pull request as ready for review November 18, 2023 07:15
@ghiscoding ghiscoding merged commit 32b2a48 into next Nov 18, 2023
3 of 5 checks passed
@ghiscoding ghiscoding deleted the feat/move-slickgrid-core-to-internal branch November 18, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants