Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): col name from HTML shouldn't disappear in picker, fixes #1475 #1476

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix(core): col name from HTML shouldn't disappear in picker, fixes #1475 #1476

merged 1 commit into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. fix(core): col name from HTML shouldn't disappear in picker, fixes #1475 

    

- when unselecting any column from ColumnPicker/GridMenu it was causing columns created from native HTML element to disappear, I'm not exactly sure why but it looks like if I clone the node before calling `.appendChild` then the problem no longer exists. For reference, the issue is from these lines
https://github.com/ghiscoding/slickgrid-universal/blob/185b6f9e44400bec2f1d79568905ca79e4b338a5/packages/common/src/core/slickGrid.ts#L1615-L1616
    @ghiscoding
    ghiscoding committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9559bcf View commit details
    Browse the repository at this point in the history