Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exports): should be able to change export file name #205

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 18, 2020

ref Angular-Slickgrid issue #655

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #205 (229db5c) into master (3aca8f9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          206       206           
  Lines        11855     11857    +2     
  Branches      4055      4055           
=========================================
+ Hits         11855     11857    +2     
Impacted Files Coverage Δ
...ages/common/src/extensions/contextMenuExtension.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...ackages/common/src/services/excelExport.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/textExport.service.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)
packages/text-export/src/textExport.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aca8f9...229db5c. Read the comment docs.

@ghiscoding ghiscoding merged commit 9d26213 into master Dec 18, 2020
@ghiscoding ghiscoding deleted the bugfix/export-filename branch December 18, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant