Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): add back Slider Range filter in pure JS #784

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 31, 2022

  • this PR brings back a filter that was remove because of the jQueryUI drop, the filter is now written in pure JS without any external deps
  • also created a new SliderOption & SliderRangeOption interfaces for better typing (instead of using filter params which was not typed) and deprecate the use of filter params (accept both in the meantime)

image
image

- this PR brings back a filter that was remove because of the jQueryUI drop, the filter is now written in pure JS without any external deps
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #784 (fbe87b5) into master (0755b65) will not change coverage.
The diff coverage is 100.00%.

❗ Current head fbe87b5 differs from pull request most recent head 59ab257. Consider uploading reports for the commit 59ab257 to get more accurate results

@@            Coverage Diff             @@
##            master      #784    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          234       235     +1     
  Lines        16383     16597   +214     
  Branches      5498      5560    +62     
==========================================
+ Hits         16383     16597   +214     
Impacted Files Coverage Δ
packages/common/src/constants.ts 100.00% <100.00%> (ø)
packages/common/src/filters/filters.index.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderRangeFilter.ts 100.00% <100.00%> (ø)
packages/common/src/interfaces/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit b84525c into master Oct 31, 2022
@ghiscoding ghiscoding deleted the feat/slider-range branch October 31, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant