Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to ssh_config and sshd_config #9

Merged
merged 1 commit into from Oct 15, 2013

Conversation

jwennerberg
Copy link

PR to highlight the changes needed to be able to migrate from the current module used in the Stockholm environment.

@@ -32,13 +32,13 @@ Protocol 2

# Logging
# obsoletes QuietMode and FascistLogging
#SyslogFacility AUTH
SyslogFacility AUTHPRIV
#SyslogFacility AUTH # AUTHPRIV
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this just be

#SyslogFacility AUTHPRIV

to show the default?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. or actually

#SyslogFacility AUTH

AUTHPRIV is only available on RHEL if I'm not mistaken, and according to SSHD_CONFIG(5) AUTH is still default for RHEL.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the default value for the param should be AUTH instead of AUTHPRIV

@ghoneycutt
Copy link
Owner

@jwennerberg I noticed that you remove the commented out defaults for most of the options and I think that we should probably keep those for two reasons. What are your thoughts?

  1. the rest of the file still has them. so this is a bit weak, as the rest of the file could not have them, too.

  2. as an admin, it is nice to see the default values and what they are currently set to in order to quickly debug things.

@jwennerberg
Copy link
Author

I agree. I'll readd the comments with the default values

@ghoneycutt ghoneycutt merged commit 272b3e4 into ghoneycutt:master Oct 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants