Add yum::repo ensure => absent functionality #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch puppet-lint 2.3.1 results in this error in Ruby 1.8.7:
SyntaxError: /home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint/configuration.rb:53: undefined (?...) sequence: /^(?<option>\w+)=?$/
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint.rb:7:in `gem_original_require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint.rb:7:in `require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint.rb:7
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint/tasks/puppet-lint.rb:1:in `gem_original_require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint/tasks/puppet-lint.rb:1:in `require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppet-lint-2.3.1/lib/puppet-lint/tasks/puppet-lint.rb:1
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppetlabs_spec_helper-2.0.2/lib/puppetlabs_spec_helper/rake_tasks.rb:438:in `gem_original_require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppetlabs_spec_helper-2.0.2/lib/puppetlabs_spec_helper/rake_tasks.rb:438:in `require'
/home/travis/.rvm/gems/ruby-1.8.7-p371/gems/puppetlabs_spec_helper-2.0.2/lib/puppetlabs_spec_helper/rake_tasks.rb:438
/home/travis/build/nytm/puppet-module-confluence/Rakefile:1:in `gem_original_require'
/home/travis/build/nytm/puppet-module-confluence/Rakefile:1:in `require'
/home/travis/build/nytm/puppet-module-confluence/Rakefile:1
/home/travis/.rvm/gems/ruby-1.8.7-p371/bin/ruby_executable_hooks:15
(See full trace by running task with --trace)
The issue has been filed upstream as rodjek/puppet-lint#759
jeffmccune
force-pushed
the
yum_repo_ensure_absent
branch
2 times, most recently
from
59aac67
to
be3335b
Compare
ghoneycutt
requested changes
Sep 28, 2017
| @@ -155,7 +164,6 @@ | |||
|
|
|||
| # Only need to deal with importing GPG keys, if we have gpgcheck enabled | |||
There was a problem hiding this comment.
Need a conditional around the existing conditional and code for yum::rpm_gpg_key
if $ensure == 'present' {
<existing code>
}There was a problem hiding this comment.
Added ensure == 'present' condition.
| @@ -232,6 +232,16 @@ | |||
| it { should contain_file('rspec.repo').with_content(/\[rspec\][\s\S]*sslcacert=\/path\/to\/cert/) } | |||
| end | |||
|
|
|||
| context 'with ensure set to valid string "absent"' do | |||
| let(:params) { mandatory_params.merge({ :ensure => 'absent' }) } | |||
| it { should contain_file('rspec.repo').with_ensure('absent') } | |||
There was a problem hiding this comment.
it { is_expected.to have_yum__rpm_gpg_key_resource_count(0) }There was a problem hiding this comment.
Thanks, added the test.
Without this patch, puppet cannot easily remove specific yum repositories. This is a problem in situations where the directory cannot be fully purged due to unmanaged files and when a specific configuration needs to be removed from specific nodes.
jeffmccune
force-pushed
the
yum_repo_ensure_absent
branch
from
be3335b
to
8928ba7
Compare
|
@ghoneycutt Requested changes have been made. |
ghoneycutt
approved these changes
Sep 28, 2017
|
Released in v1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, puppet cannot easily remove specific yum
repositories. This is a problem in situations where the
directory cannot be fully purged due to unmanaged files and
when a specific configuration needs to be removed from specific
nodes.