Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modal toggling and tracking all active modal instances #363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swg
Copy link

@swg swg commented Aug 10, 2020

This pull requests adds support for closing all active modal instances (if no target modal is passed) and enables "toggling" of modals with onShow. Previously this behavior was buggy, and would only ref the last activeModal for closing.

@auriel-klasovksy
Copy link

This is perfect. Thank you very much, hope this gets pulled.

@kauaicreative
Copy link

Watching for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants