Render directives at the top of the schema #1270
Conversation
| case __DirectiveLocation.QUERY => "QUERY" | ||
| case __DirectiveLocation.MUTATION => "MUTATION" | ||
| case __DirectiveLocation.SUBSCRIPTION => "SUBSCRIPTION" | ||
| case __DirectiveLocation.FIELD => "FIELD" | ||
| case __DirectiveLocation.FRAGMENT_DEFINITION => "FRAGMENT_DEFINITION" | ||
| case __DirectiveLocation.FRAGMENT_SPREAD => "FRAGMENT_SPREAD" | ||
| case __DirectiveLocation.INLINE_FRAGMENT => "INLINE_FRAGMENT" | ||
| case __DirectiveLocation.SCHEMA => "SCHEMA" | ||
| case __DirectiveLocation.SCALAR => "SCALAR" | ||
| case __DirectiveLocation.OBJECT => "OBJECT" | ||
| case __DirectiveLocation.FIELD_DEFINITION => "FIELD_DEFINITION" | ||
| case __DirectiveLocation.ARGUMENT_DEFINITION => "ARGUMENT_DEFINITION" | ||
| case __DirectiveLocation.INTERFACE => "INTERFACE" | ||
| case __DirectiveLocation.UNION => "UNION" | ||
| case __DirectiveLocation.ENUM => "ENUM" | ||
| case __DirectiveLocation.ENUM_VALUE => "ENUM_VALUE" | ||
| case __DirectiveLocation.INPUT_OBJECT => "INPUT_OBJECT" | ||
| case __DirectiveLocation.INPUT_FIELD_DEFINITION => "INPUT_FIELD_DEFINITION" |
There was a problem hiding this comment.
This is a copy paste to the __DirectiveLocation code. Wasn't sure if we wanted to somehow encode the string version of the location in the case object?
| } | ||
| val directiveLocations = locationStrings.mkString(" | ") | ||
|
|
||
| val body = s"""directive @${directive.name}${inputs} repeatable on ${directiveLocations}""".stripMargin |
There was a problem hiding this comment.
Should we add repeatable: Boolean to directives with default to true?
There was a problem hiding this comment.
Oh shoot I meant to ask about this. Right now it's hard-coded as repeatable. I didn't look at what we did for this with the introspection API but it would be good to allow it to be set as non-repeatable.
There was a problem hiding this comment.
Ah this keyword is new in the 2021 spec, which is why it was not there before. Would be nice to add (otherwise, don't include the keyword).
There was a problem hiding this comment.
Cool, let me see what I can do about adding it.
There was a problem hiding this comment.
On the top of my head, it should be added in the parser, in the Directive and __Directive classes, and maybe a validation rule should be added to check there is only one given if not repeatable.
If that's too much, it can be done in another PR 😄
There was a problem hiding this comment.
Cool. Yeah I will remove the repeatable statement for now, and then do another PR to add repeatable.
|
@ghostdogpr removed the I'll start on the second PR to add |
Any custom
__Directivesadded to the schema as part of theGraphQL.graphQLmethod do not render when thegraph.render()method is called. This PR adds support for that.