-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing directive rendering for derrived types #1275
Add missing directive rendering for derrived types #1275
Conversation
I think there is technically one more place that we are missing which is the schema @directive {
query: Query
} I think we could possibly modify the |
I'd probably say add a |
For schema directives, can't we just pass them to |
So per #1270, the directives passed there now rendered in the full schema SDL (as well as being part of the introspection schema as the were previous to that PR). We could also apply those to the I'll also say, long-term I would probably argue that we should collect all directives used by all types in the SDL, and render them in the schema automatically (since they are used in the schema) vs using them in the schema + also having to remember to pass them in to |
Did you mean to merge this? |
Adds rendering of directives for unions, enums, interfaces, and input objects whose schemas are automatically derived. Doing so required adding
directives
arguments to the various helper methods inTypes
, and the extracting the directives out inside the scala 2 and 3SchemaDerrivation
traits to pass in to those new arguments.I also updated the test schema used in
RenderingSpec
to add directives to the various parts of the schema that were missing them.