Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fast-hosts-lookup like other engines #2144

Merged
merged 1 commit into from
Aug 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/adblocker-benchmarks/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ adblockpluscore: ./node_modules/adblockpluscore

tsurlfilter-node: ./node_modules/@adguard/tsurlfilter

./node_modules/fast-hosts-lookup:
npm install --no-save mjethani/fast-hosts-lookup

fast-hosts-lookup: ./node_modules/fast-hosts-lookup

./node_modules/adblock-rs:
npm install --no-save adblock-rs

Expand Down Expand Up @@ -90,4 +95,4 @@ run: deps url tldts cliqz ublock adblockplus brave adblockfast

clean:
rm -f requests.json
npm uninstall @adguard/tsurlfilter adblockpluscore @gorhill/ubo-core adblock-rs
npm uninstall fast-hosts-lookup @adguard/tsurlfilter adblockpluscore @gorhill/ubo-core adblock-rs
5 changes: 3 additions & 2 deletions packages/adblocker-benchmarks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,14 @@
"download-abp": "make adblockpluscore",
"download-tsurlfilter": "make tsurlfilter-node",
"download-brave": "make adblock-rs",
"prepare": "yarn download-requests && yarn download-ubo && yarn download-abp && yarn download-tsurlfilter && yarn download-brave"
"download-fast-hosts-lookup": "make fast-hosts-lookup",
"prepare": "yarn download-requests && yarn download-ubo && yarn download-abp && yarn download-tsurlfilter && yarn download-brave && yarn download-fast-hosts-lookup"
},
"bugs": {
"url": "https://github.com/cliqz-oss/adblocker/issues"
},
"peerDependencies": {
"fast-hosts-lookup": "github:mjethani/fast-hosts-lookup#9136bb8c331ee5dba8ac1a0018552cace11e2afa",
"@adguard/tsurlfilter": "^0.5.24",
"adblock-rs": "^0.3.15",
"adblockpluscore": "^0.3.1",
Expand Down Expand Up @@ -71,7 +73,6 @@
"devDependencies": {
"@rollup/plugin-commonjs": "^20.0.0",
"@rollup/plugin-json": "^4.1.0",
"fast-hosts-lookup": "github:mjethani/fast-hosts-lookup",
"rollup": "^2.55.1",
"rollup-plugin-terser": "^7.0.2"
}
Expand Down