Don't throw an error when receiving a message from popup #2506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cliqz/adblocker-webextension breaks message passing from popup to background page.
handleRuntimeMessage
always throws an error here, becausesender
from popup never containstab
andframeId
:adblocker/packages/adblocker-webextension/adblocker.ts
Lines 305 to 315 in f4c7ce4
This stops other async message listeners from executing.
This PR fixes it by checking for correct message action before
sender.tab
/frameId
.