Enhancements - Comparing results with uBO #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GRadziejewski
commented
Apr 10, 2024
•
GRadziejewski
commented
- Delete profiles and measurements
- Add other extensions to compare to (example uBlock Origin)
- Show the results
…y/benchmarks into enhancements-compare-uBO
There was a problem hiding this comment.
If Firefox takes 1,162,466.08 sec and Chrome 988,810.84, you have "117.56% faster". Looking at the number, I assume you mean 17.56% faster (or a speedup of 1.1756).
1162466.08 / 988810.84 = 1.1756 (so it is 17.56% faster or 1.1756 times faster)
There was a problem hiding this comment.
Also, in such graphs, I find it always helpful to say either "Fewer is better" or "More is better".
For instance here: "Total Load Time Ratio, More is better"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.