Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applinks support for contribution link #1062

Closed
wants to merge 1 commit into from
Closed

Conversation

smalluban
Copy link
Collaborator

@smalluban smalluban commented Mar 10, 2023

Fixes #1020

  • Followed Apple documentation to setup associated domain on ghostery.com
  • Configured entitlements in XCode

It looks like everything is configured correctly, but I can't make it work. The domain can be verified here: https://app-site-association.cdn-apple.com/a/v1/www.ghostery.com

To open URL on iOS simulator you can use command:

xcrun simctl openurl booted https://www.ghostery.com/become-a-contributor

@smalluban smalluban requested a review from chrmod March 10, 2023 10:25
@chrmod chrmod closed this Sep 9, 2023
@chrmod
Copy link
Member

chrmod commented Sep 9, 2023

@smalluban looks like https://www.ghostery.com/.well-known/apple-app-site-association was incorrect. I've made a fix, lets try again.

@smalluban
Copy link
Collaborator Author

smalluban commented Sep 14, 2023

@chrmod I've checked the app links, and your change seems to help. But unfortunately, the effect is probably not what we expected. The page opens anyway, but there is a "bar" at the top informing you that you can open it in the application. Maybe linking to the account would change something...

But on the SwiftUI side, I give up. This is extremely unintuitive, and I have no idea how to refer to a view to fire a method on it. I was looking for a solution, but of course, it's kind of wild. Maybe it's our implementation because there is no normal routing there.

Here you have a place to make a call: https://github.com/ghostery/ghostery-extension/blob/8a390c9686298e340328f6eb0a392b07dba218dd/extension-manifest-v3/xcode/iOS%20(App)/GhosteryApp.swift

Zrzut ekranu 2023-09-13 o 15 52 06

@smalluban
Copy link
Collaborator Author

This is unlikely to be implemented at all. Closing for now.

@smalluban smalluban closed this Jun 21, 2024
@chrmod
Copy link
Member

chrmod commented Jun 28, 2024

I would actually prefer to figure it out. Maybe it will work differently under the new apple developer account.

@chrmod chrmod reopened this Jun 28, 2024
@smalluban smalluban closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari: Become a contributor should open an native app
2 participants