(8.5.4) GH-2153: Future-proof metrics uninstall URL #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlycdgr
changed the title
wlycdgr
reviewed
Oct 2, 2020
src/classes/Metrics.js
Outdated
| * | ||
| * @private | ||
| * | ||
| * @since 8.5.3 |
There was a problem hiding this comment.
My bad, let's bump this to 8.5.4
wlycdgr
changed the title
wlycdgr
approved these changes
Oct 26, 2020
chrmod
pushed a commit
that referenced
this pull request
Jul 28, 2022
* Use only crucial params for uninstall type * Move some query string construction to helper * Group METRICS_URL_SET with other consts * Syntax fix Co-authored-by: Ilya Zarembsky <ilya.zarembsky@gmail.com> Co-authored-by: Christopher Tino <4699516+christophertino@users.noreply.github.com>
chrmod
pushed a commit
that referenced
this pull request
Jul 29, 2022
* Use only crucial params for uninstall type * Move some query string construction to helper * Group METRICS_URL_SET with other consts * Syntax fix Co-authored-by: Ilya Zarembsky <ilya.zarembsky@gmail.com> Co-authored-by: Christopher Tino <4699516+christophertino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortens the query string for the uninstall URL by including only the ping params we've deemed as crucial.
I've also added a helper method for constructing the query string key value pairs, which hopefully makes it a little easier to read/identify the queries and values getting added to
metrics_url, and helps prevent potential errors when adding new params.