Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BetterFox #484

Merged
merged 4 commits into from
Feb 13, 2021
Merged

BetterFox #484

merged 4 commits into from
Feb 13, 2021

Conversation

yokoffing
Copy link
Contributor

@yokoffing yokoffing commented Feb 10, 2021

Acknowledgement

Thank you for inviting me to be apart of the Ghostery team at a community level!

Purpose

This file will give everyday mainstream users the optimal privacy, security, and annoyance-free settings right out-of-the-box. BetterFox was designed to allow users as much privacy as possible up to the point of experiencing breakage.

Notes

From the original BetterFox user.js, I have flagged for removal:

  • numerous prefs I've already added to the firefox-branding.js, which disables Mozilla-specfic products;
  • prefs that Mozilla preconfigures each release by user hardware (e.g., Webrender vs. Webrender Software).

I also excluded:

  • disabling the pref that asks the user to be the default browser. Users will still be asked to make Ghostery Dawn their default browser on launch.
  • prefs that disabled the password manager, the address and credit card manager, and Google Safe Browsing. Therefore, Ghostery Dawn will use the same defaults that Mozilla uses when you first download the browser. (We may have to tinker with these down the road depending on user feedback, especially the auto-fill preferences. I don't use any of those features.);
  • force disabling accessibility services;
  • toolkit.legacyUserProfileCustomizations.stylesheets from being true by default, so users will still need to enable this manually. We can enable this by default if you're okay with the small start-up performance hit for all users;
  • Firefox Beta/Developer, Nightly prefs.

Users can still modify features in about:config or with a user.js file.

These prefs mentioned above are commented out using // . When everyone has signed off on these, I will remove them totally. This will reduce the clutter of unneeded code.


I have retained most things, but two prefs I want to be sure you're aware of:

  • disabled search suggestions in the address bar by default so that not every character typed goes directly to the search engine, even when a user is typing in a web address and not a search query; [privacy]
  • block new requests asking to allow notifications [annoyance]

Search suggestions in the address bar from the default search provider and allowing websites to ask users for website notifications are enabled on most (all?) web browsers. However, this can be two unique selling points in that Ghostery Dawn respects user privacy in search and blocks a common annoyance right out-of-the-box. :)

The Ghostery team may want to change some of these. Just let me know what you'd like to change and I can make the appropriate alterations.

Closing

Thank you for helping achieve the goal of privacy by default.

If you'd like more detail on what a pref does, please see the appropriate section from my repo (SecureFox, PeskyFox) and read the description. Feel free to comment here if you have a question.

Clarifications

09 Feb 2021
Reminder: Prefs flagged to be removed are commented out using // . When everyone has signed off on these, I will remove them totally. This will reduce the clutter of unneeded code.

10 Feb 2021
Corrections:

  • pref("browser.urlbar.suggest.bookmark", true); was wrongly listed as 'bookmarks' (pref is singular, not plural)
  • pref("javascript.options.warp", true); has been removed from about:config. Javascript WARP is permanently implemented by Mozilla (yay!)
  • Commented out pref("geo.provider.network.url", "https://location.services.mozilla.com/v1/geolocate?key=%MOZILLA_API_KEY%") for now (see issue Use Mozilla geolocation service API instead of the default Google one. #405)

* pref("browser.urlbar.suggest.bookmark", true); was wrongly listed as 'bookmarks' (pref is singular, not plural)
* pref("javascript.options.warp", true); has been removed from about:config. Javascript WARP is permanently implemented by Mozilla (yay!)
* Commented out pref("geo.provider.network.url", "https://location.services.mozilla.com/v1/geolocate?key=%MOZILLA_API_KEY%") for now (see issue #405)
Copy link
Contributor

@2br-2b 2br-2b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all of the preferences I understood (and researched some of them), and I've left my comments

brands/ghostery/branding/pref/Better-Fox.js Outdated Show resolved Hide resolved
brands/ghostery/branding/pref/Better-Fox.js Outdated Show resolved Hide resolved
brands/ghostery/branding/pref/Better-Fox.js Outdated Show resolved Hide resolved
brands/ghostery/branding/pref/Better-Fox.js Outdated Show resolved Hide resolved
brands/ghostery/branding/pref/Better-Fox.js Outdated Show resolved Hide resolved
@2br-2b
Copy link
Contributor

2br-2b commented Feb 11, 2021

Also, I noticed that some of these options are already the defaults. I can go through and find which are the default options so they can be removed

@2br-2b 2br-2b mentioned this pull request Feb 11, 2021
Restored and brought over tfrom the firefox-branding.js:
pref("network.cookie.sameSite.laxByDefault", true);
pref("network.cookie.sameSite.noneRequiresSecure", true);
// pref("network.cookie.sameSite.schemeful", true); (commented out until further testing)
pref("privacy.webrtc.globalMuteToggles", true);

Removed:
pref("browser.aboutConfig.showWarning", false); 

Code cleanup:
prefs flagged for removal in Fastfox 
prefs flagged for removal at the start of SecureFox (already covered in branding.js)
prefs under "Mozilla UI" already in branding.js
prefs under "Pocket" already in branding.js
prefs under "New Tab Page / Activity Stream" already in branding.js
Copy link
Member

@chrmod chrmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged as soon comments from the original firefox-prefs.js will get copied over.

Great work @yokoffing, thank you!

pref("browser.urlbar.suggest.history", true);
pref("browser.urlbar.suggest.openpage", false);
pref("browser.urlbar.suggest.searches", false);
pref("browser.urlbar.suggest.topsites", false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about we enable this? It seems to be useful and as the list is stored locally it is private. I realize that it was disabled till now, but as we disable query suggestion maybe we can bring this in instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For topsites, the original firefox-branding.js had this note:

Disable dropdown suggestions with empty query.

So if we enable this to true, suggestions would show even though the user hasn't typed anything. Conversely, we have history and bookmark enabled to show when a user starts typing in the URL bar.

Topsites is random clutter, IMO. I bookmark every site I use with frequency, but I understand that not every uses their web browser like me ;)

@chrmod
Copy link
Member

chrmod commented Feb 12, 2021

@2br-2b Thank you for your help on this one. It's great to have another pair of eyes looking at those things! 👍🏻

Removed defaults:
pref("browser.cache.disk.enable", true); 
pref("browser.cache.offline.enable", true); 
pref("security.tls.version.enable-deprecated", false);
pref("dom.targetBlankNoOpener.enabled", true);
pref("browser.safebrowsing.downloads.remote.url", "");
pref("media.autoplay.default", 1);
pref("browser.backspace_action", 2);
pref("pdfjs.disabled", false);
pref("browser.helperApps.showOpenOptionForPdfJS", true);
pref("privacy.popups.showBrowserMessage", true);

Removed prefs flagged for removal:
pref("dom.push.userAgentID", "");
prefs under PASSWORDS AND AUTOFILL, ADDRESS + CREDIT CARD MANAGER
pref("accessibility.force_disabled", 1);
pref("pdfjs.defaultZoomValue", "page-width");
@chrmod chrmod changed the title BetterFox Draft BetterFox Feb 13, 2021
Copy link
Member

@chrmod chrmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks just great! Thank you @yokoffing !

@chrmod chrmod merged commit 0f0214d into ghostery:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants