Update FacebookProvider to get access_token from json body rather tha… #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n query parameter
|
Awesome, thank you @undrewb |
fmpwizard
suggested changes
Apr 3, 2017
|
|
||
| } catch { | ||
| case unknown : Throwable => { | ||
| println("Something went wrong with the access_token" + unknown) |
There was a problem hiding this comment.
logger.error would be better here
| validToken = validateToken(accessToken) | ||
|
|
||
| } catch { | ||
| case unknown : Throwable => { |
There was a problem hiding this comment.
it's better to use NonFatal http://www.scala-lang.org/api/2.9.3/scala/util/control/NonFatal$.html
instead of Throwable, because Throwable also includes things like out of memory errors which you don't want to really catch
|
Will merge after you address comments from @fmpwizard :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update FacebookProvider to get access_token from json body rather than query parameter. The query parameter no longer exists.