Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of the plugin without panda installed #332

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

Gustry
Copy link
Collaborator

@Gustry Gustry commented Jul 3, 2023

Fix to #331

Maybe a more visible warning will be better to invite users to install it. But at least, the plugin can load without a Python error

Copy link
Owner

@ghtmtt ghtmtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gustry thanks for the fix! Just some minor comments

DataPlotly/processing/dataplotly_provider.py Outdated Show resolved Hide resolved
DataPlotly/processing/dataplotly_provider.py Outdated Show resolved Hide resolved
DataPlotly/processing/dataplotly_provider.py Outdated Show resolved Hide resolved
DataPlotly/processing/dataplotly_provider.py Outdated Show resolved Hide resolved
@ghtmtt ghtmtt merged commit e14209b into ghtmtt:master Jul 4, 2023
3 checks passed
@ghtmtt
Copy link
Owner

ghtmtt commented Jul 4, 2023

thanks @Gustry!

@Gustry Gustry deleted the panda branch July 4, 2023 14:04
@agiudiceandrea
Copy link
Contributor

@ghtmtt @Gustry , when will the new version be released?
See https://lists.osgeo.org/pipermail/qgis-user/2023-November/053625.html.

@ghtmtt
Copy link
Owner

ghtmtt commented Nov 13, 2023

@agiudiceandrea we don't have a release roadmap and given that at the moment we don't have any major updates to publish, I was thinking to wait for some new features to add

@Gustry
Copy link
Collaborator Author

Gustry commented Nov 13, 2023

@ghtmtt As this Python exception was raised when loading the plugin every time when QGIS is starting, this bug was a real blocker. The plugin is totally not loaded when such error occur. (not only when we want to use Processing, but just to open the dock)

@ghtmtt
Copy link
Owner

ghtmtt commented Nov 15, 2023

release 4.1.0 made! Thanks @Gustry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants