Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangeSlider: inverted label order with small range #144

Closed
grpiedade opened this issue Nov 7, 2013 · 9 comments
Closed

DateRangeSlider: inverted label order with small range #144

grpiedade opened this issue Nov 7, 2013 · 9 comments
Labels

Comments

@grpiedade
Copy link

The labels are inverted when the min / max values (changed programmatically) are too close.

Reproduce:
http://jsfiddle.net/grpiedade/L48jY/
Click Run and watch as the seconds increase. The labels order will be inverted for some time, then there will be just one label and finally the labels will be correct as expected.
The range needed to get the labels in the correct order varies depending on the slider size.

@grpiedade
Copy link
Author

Is this really a bug or am I doing something wrong?

@ghusse
Copy link
Owner

ghusse commented Nov 27, 2013

It is probably a bug introduced in latest version. It changed how handles
are placed.
Le 27 nov. 2013 13:12, "grpiedade" notifications@github.com a écrit :

Is this really a bug or am I doing something wrong?


Reply to this email directly or view it on GitHubhttps://github.com//issues/144#issuecomment-29379836
.

@jamienk
Copy link

jamienk commented Jan 8, 2014

This is a blocker for me. Can you point me to the area where this method is? I can't easily find it in the code. I will do a pull request if I'm able to fix it... Thanks in advance.

@ghusse
Copy link
Owner

ghusse commented Jan 9, 2014

Nice !

This object is responsible for positionning labels: https://github.com/ghusse/jQRangeSlider/blob/master/jQRangeSliderLabel.js#L215

@ghusse
Copy link
Owner

ghusse commented Feb 1, 2014

Fixed in 5.6.0

@ghost
Copy link

ghost commented Feb 12, 2014

I'm using 5.6.0 with jqueryui 1.10.3 and jquery 1.10.2 and it seems the problem is still persistent. The #146 too

@ghost
Copy link

ghost commented Feb 28, 2014

Anyone got this again?

@noelsison
Copy link

Yes, still inverted on close min and max values when using jQDateRangeSlider. Happens when setting the minimum date.

@grpiedade
Copy link
Author

Long time I don't visit this. I tested 5.7.0 now and the issue is fixed.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants