major rewrite of bcea() and ceac.plot() #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
several small refactoring (safer) * change from . to _ separators * c,e to cost, eff mainly because c is a built in function * error asserts at top of bcea.default
now need to test...
runs but doesnt create output for vi,Ustar, ol, evi associated tests fail
…arranging and low handing fruit.
ceac.plot
…ut much better than before
…o with all of the conditional statements.
need to edit prepare_graph_params_ceplane()
…() apart into smaller functions similar to ceac.plot but haven't finished
realised theres loads of overlap with ceac_multi and already rewritten ceac.plot. Also plot.bcea() definitely doesnt run right now...
changes the dispatch to lower level funcitons
…t ceac for pairwise
not tested
Total rewrite of ceac.plot()
Change license to GPL
update data docs
|
I think so. An if it needs slight changes it should be easy from now on. |
|
Perfect---thank you. I'll give it a couple of days and then when I have a
moment, I'll write a blog post and update people (who asked for the changes
in the first place...).
…On Tue, 21 Jul 2020 at 18:21, Dr Nathan Green ***@***.***> wrote:
I *think* so. An if it needs slight changes it should be easy from now on.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#21 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCRVSOIO46CZHRSU365RK3R4XFANANCNFSM4PDUJHQA>
.
--
*Gianluca Baio*
*Professor of Statistics & Health Economics*
Department of Statistical Science
University College London
1-19 Torrington Place, London WC1E 6BT, UK
Telephone +44(0)20 7679 1248 (internal: 41248)
Fax +44 (0)20 7383 4703
Website: http://www.homepages.ucl.ac.uk/~ucakgba
<http://www.homepages.ucl.ac.uk/~ucakgba/>
Blog: http:www.statistica.it/gianluca/blog
<https://twitter.com/gianlubaio>
<https://www.linkedin.com/in/gianluca-baio-b893879/>
<https://github.com/giabaio>
<https://scholar.google.co.uk/citations?user=ro0QvGsAAAAJ&hl=en>
<https://www.researchgate.net/profile/Gianluca_Baio>
<https://orcid.org/0000-0003-4314-2570>
*DUE TO THE COVID-19 EMERGENCY, I WILL PROBABLY HAVE ERRATIC WORKING HOURS
IN THE NEXT FEW DAYS/WEEKS/MONTHS/YEARS. I MAY BE SLOWER IN REPLYING TO
EMAILS OR SEND THEM AT UNGODLY HOURS. PLEASE BEAR WITH ME.*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why theres a merge conflict without looking in to it because I thought I forked the latest version but you'll know better than me.
There are a lot of changes, both large and small.
This certainly needs a good code review. Realistically, I think it could take a bit of time to do this properly.
Outstanding things to do are: