Propose move to navbarPage #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move to navbarPage (shinyDashboard might be a good alternative, but would require a bit more work) 2. Included but commented out logo in top-left navbar corner 3. Other minor changes related to the above points
Reverted to simple title in navbar
Pound sign to HTML entity
Move to navbarPage
giabaio
approved these changes
Jul 16, 2018
giabaio
approved these changes
Jul 16, 2018
|
Andrea --- thanks. The dashboard looks nice and sleek!
Thanks for the work on this!!
G
*Gianluca Baio*
*Reader in Statistics & Health Economics*
Department of Statistical Science
University College London
1-19 Torrington Place, London WC1E 6BT, UK
Telephone +44(0)20 7679 1248 (internal: 41248)
Fax +44 (0)20 7383 4703
Website: http://www.homepages.ucl.ac.uk/~ucakgba
<http://www.homepages.ucl.ac.uk/~ucakgba/>
Blog: http:www.statistica.it/gianluca/blog
<https://www.linkedin.com/in/gianluca-baio-b893879/>
<https://www.facebook.com/gianluca.baio.1> <https://github.com/giabaio>
<https://plus.google.com/u/0/+GianlucaBaio>
<https://scholar.google.co.uk/citations?user=ro0QvGsAAAAJ&hl=en>
<https://www.researchgate.net/profile/Gianluca_Baio>
<https://orcid.org/0000-0003-4314-2570>
…On Sat, 14 Jul 2018 at 11:13, andbe ***@***.***> wrote:
Propose move to navbarPage
Other edits:
- Reformatted text flow in welcome page
- Included links to welcome page images on click (open to a new page)
- Justified text throughout
- Removed repeated CSS formatting
Included but commented out:
- Include logo in top-left corner of navbar
------------------------------
You can view, comment on, or merge this pull request online at:
#3
Commit Summary
- Propose move to navbarPage
- Logo code chunks were not commented out
- Fixed pound sign
- Merge pull request #1 from andbe/patch-1
File Changes
- *M* inst/BCEAweb/ui.R
<https://github.com/giabaio/BCEA/pull/3/files#diff-0> (1196)
Patch Links:
- https://github.com/giabaio/BCEA/pull/3.patch
- https://github.com/giabaio/BCEA/pull/3.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIUayfeSD0Q7IkQvlMatYJefbIHo-HoKks5uGcRGgaJpZM4VPznr>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose move to navbarPage
Other edits:
Included but commented out: