refactored evppi and fixed some small bugs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass ... from bcea.plot to ceac.plot
big merge into master after evppi work
v2.4.2 release on CRAN
lcolladotor/biocthis#27 so changed to `error=TRUE` in RMarkdown doc for `ceef.Rmd` to see if this will just get it to pass. This seems to be something to do with fonts or trying to plot outside the plotting area. The log says its using UTF-8 so perhaps need to explicityl say this beforehand? The vignettes all build fine inside RStudio including using `devtools::check_mac_version()`
dev to main
merging in to main rather than dev as requested
Merge pull request #45 from n8thangreen/dev
Update README.md
* compare all list elements
* wasn't using subset in evppi_voi * wasn't testing same random sample so added set.seed(). This is a bit fragile because depend on the number random operations in each of the functions
* still a couple of errors to fix but mostly there now
… be removing this function from the package so to still do the regression testing we need to save the function output to testdata/
* smoking_output data now has same number of rows as e,c * fitted values have the correct number of columns (4) TODO * fitted values columns are in different order. what is the correct one? can we lable the columns to be clearer? * why are the evppi and fitted values exactly the same in both methods, even with the same seed?
…all of them regardless * still not the right order of columns in fitted.values * different values in the two evppi version when number of itnerventions > 2??
* deleted evppi helper functions
* remove .Random.seed from Smoking.RData
|
Actually, let's keep the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.