Wip fix resubscribe on reconnect issue #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connect so that the parent can reacto to the disconnet.
that get sent some time after SubscribeAck, when the subscription is complete and ready to receive publishes. Updated test to account for this.
Implement SubscribeSuccess and SubscribeFailure messages
…opic already exists.
Changed to resubscribe to the Eclipse paho client event also when a t…
…opic already exists.
Changed to resubscribe to the Eclipse paho client event also when a t…
…opic already exists.
| @@ -143,7 +148,7 @@ import MqttPubSub._ | |||
| * 1. MqttClientPersistence will be set to null. @see org.eclipse.paho.client.mqttv3.MqttMessage#setQos(int) | |||
| * 2. MQTT client will auto-reconnect | |||
| */ | |||
| class MqttPubSub(cfg: PSConfig) extends FSM[S, Unit] { | |||
| class MqttPubSub(cfg: PSConfig, connectListener: Option[ActorRef] = None) extends FSM[S, Unit] { | |||
There was a problem hiding this comment.
Are connectListener param and object ConnectedToBroker not related to issue #2?
If so, do you need those stuff? @aiacovella
|
Thank you for your contribution. The issue #2 is now fixed. I will close this PR without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.