check http response and contributing guidilines

giacbrd · Jul 31, 2019 · 6d443f5 · 6d443f5
1 parent a0590d4
commit 6d443f5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
@@ -0,0 +1,8 @@
+Contributing
+============
+
+- Anyone can contribute through Pull Requests
+- Contributions should start by creating a feature/fix branch from the **develop** branch
+- Following the PEP 8 conventions is advisable
+- Starting an *issue* before contributing is advisable
+- Tests must pass, unit tests specific to the contribution are mandatory
diff --git a/dandelion/base.py b/dandelion/base.py
@@ -88,6 +88,7 @@ def do_request(self, params, extra_url='', method='post', **kwargs):
             response = self.cache.get(cache_key)
         else:
             response = self._do_raw_request(url, params, method, **kwargs)
+            response.raise_for_status()
             if response.ok:
                 self.cache.set(cache_key, response)