-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blasfeo windows support #119
Conversation
Thanks! It looks like gcc is not happy about replacing all I guess the issue about visual studio and |
Happy to test whatever you come up with. I'll try to have a look myself later today. Cheers.
|
This reverts commit f78b4e2.
… * from VS. Examples don't need to be linked to m.lib since MSVC deals with the maths
Hi @TureganoJose at the end gcc was still not happy about the changes. So I started from scratch and made all changes in your PR in a way that gcc likes. |
Thanks for that @giaf. I've given it a go but it still complains about (void *). See image below. |
Hi @TureganoJose hopefully this will make the compiler happy now Can you give another try? |
It does work now! See some instructions to build from CMake and to compile the examples. C:/Program Files (x86)/Microsoft Visual Studio/2017/WDExpress/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x64/cl.exe CMake Error at CMakeLists.txt:199 (message): Maths are dealt by MSCVR in Windows, m.lib needs to be removed from all the examples. This step is not necessary to build blasfeo library. |
Hi @TureganoJose great that it works :) Now I will merge my branch on windows support into master, close this PR and create an issue about window support pointing to this PR. Since only the GENERIC target works with visual studio, the next step to improve support would be to check if the compiler can properly auto-vectorize the GENERIC code, and if not tweak it accordingly. |
|
I haven't tested completely. It solves some of the examples and I built a static library which I hooked up with hpipm and it seems to solve fine.
All I've done is switching to generic target, build the solution with CMake (tested with VS Express 2017 and compiler VC++ 2013) and then replaced all the void* with char*. I don't know if that would be an issue with gcc.
I hope it helps.
Regards,
Jose