Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small issues #53

Closed
tsijs opened this issue Oct 26, 2018 · 2 comments
Closed

Some small issues #53

tsijs opened this issue Oct 26, 2018 · 2 comments

Comments

@tsijs
Copy link

tsijs commented Oct 26, 2018

I am compiling hpipm in one big .c file for embedded use, and I came across some minor issues:

It seems that include/hpipm_d_core_qp_ipm.h and include/hpipm_s_core_qp_ipm.h have no header guard.

in the d_<problem_class>_kkt.c files, the following function placeholders are not declared:
COND_SLACKS_FACT_SOLVE
COND_SLACKS_SOLVE
EXPAND_SLACKS

@giaf
Copy link
Owner

giaf commented Oct 29, 2018

This fixes the include guard 450a5ca

About the undeclared function placeholders, they are all static functions, so they are only used within the file.c and they don't need a global unique name. Does it cause issues to you?

@tsijs
Copy link
Author

tsijs commented Oct 29, 2018

Aha, okay that would make sense. It created issues for me, but that is only because I needed to include all .c files in one source file for my application. But I fixed it for me by adding the placeholders.

@tsijs tsijs closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants