Renamed all shortcodes to avoid conflicts #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your plugins shortcodes are too generically named. This has caused conflicts in the past, and another one just came up. I've renamed all your shortcodes to include
Gravstrapat the start of the classname. As these are auto-discovered, and the shortcodes themselves already have agravstrap-prefix, this is 100% fully backwards compatible and shouldn't cause any issues with existing setups, and will avoid any potential conflicts going forward.Please test and confirm, and release a new version as soon as possible. Thanks!