Get bastion SSH users from installations instead of hard-coding

[tfussell]

No description provided.

[xh3b4sd]

What should we do with this PR?

[tfussell]

I worked on it in the last sig-releng working hours. It was for this issue https://github.com/giantswarm/giantswarm/issues/6049 I'd like to finish it up at some point, but the 1.15.4 release is the top priority at the moment. I'll try to wrap this up in the next week.

[xh3b4sd]

Check

aws-operator/integration/setup/setup.go

Lines 306 to 337 in 61b2eed

	func newSSHUserList(ctx context.Context, config Config) (string, error) {
	var err error
	var privateRepo *privaterepo.PrivateRepo
	{
	c := privaterepo.Config{
	Owner: "giantswarm",
	Repo: "installations",
	Token: env.GithubToken(),
	}
	privateRepo, err = privaterepo.New(c)
	if err != nil {
	return "", microerror.Mask(err)
	}
	}
	var sshUserList string
	{
	content, err := privateRepo.Content(ctx, "default-draughtsman-configmap-values.yaml")
	if err != nil {
	return "", microerror.Mask(err)
	}
	sshUserList, err = privaterepo.ContentToSSHUserList(content)
	if err != nil {
	return "", microerror.Mask(err)
	}
	}
	return sshUserList, nil
	}

. I once started to write some abstraction code for fetching information from the installations repo. Let's use this if possible.

[calvix]

just FYI this is for testing/debugging e2e only, we don't create bastions fo TC in real enviroments inclusing test envs like ginger or gauss

[xh3b4sd]

Is this PR still relevant?

[tfussell]

Is this PR still relevant?

I think I'm going down the wrong path with this. I've spent too much time on it already and it's still not working. Also I had an idea for simplifying the approach drastically. I will close this for now.