Fixing restConfigs (#1111)

* Fixing restConfigs

* Updating changelog

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s
 
 ## [Unreleased]
 
+### Fixed
+
+- Use separate rest configs for different Kubernetes clients.
+
 ## [3.2.0] - 2024-02-27
 
 ### Added

service/service.go

@@ -66,7 +66,7 @@ func New(config Config) (*Service, error) {
 	}
 
 	var err error
-	var restConfig *rest.Config
+	var restConfigPrv *rest.Config
 	{
 		c := k8srestconfig.Config{
 			Logger: config.Logger,
@@ -81,12 +81,14 @@ func New(config Config) (*Service, error) {
 			},
 		}
 
-		restConfig, err = k8srestconfig.New(c)
+		restConfigPrv, err = k8srestconfig.New(c)
 		if err != nil {
 			return nil, microerror.Mask(err)
 		}
 	}
 
+	restConfigPub := rest.CopyConfig(restConfigPrv)
+
 	fs := afero.NewOsFs()
 
 	// k8sPrvClient runs under the chart-operator default permissions and hence
@@ -95,7 +97,7 @@ func New(config Config) (*Service, error) {
 	var k8sPrvClient k8sclient.Interface
 	var prvHelmClient helmclient.Interface
 	{
-		k8sPrvClient, err = newK8sClient(config, restConfig)
+		k8sPrvClient, err = newK8sClient(config, restConfigPrv)
 		if err != nil {
 			return nil, microerror.Mask(err)
 		}
@@ -119,15 +121,15 @@ func New(config Config) (*Service, error) {
 		//     User "system:serviceaccount:default:automation" cannot create resource
 		//     "rolebindings" in API group "rbac.authorization.k8s.io" in the namespace
 		//     "giantswarm".
-		restConfig.Impersonate = rest.ImpersonationConfig{
+		restConfigPub.Impersonate = rest.ImpersonationConfig{
 			UserName: fmt.Sprintf(
 				"system:serviceaccount:%s:%s",
 				publicClientSANamespace,
 				publicClientSAName,
 			),
 		}
 
-		k8sPubClient, err = newK8sClient(config, restConfig)
+		k8sPubClient, err = newK8sClient(config, restConfigPub)
 		if err != nil {
 			return nil, microerror.Mask(err)
 		}