Skip to content

Commit

Permalink
Override image repository because kubeadm of Kubernetes v1.23.15 trie…
Browse files Browse the repository at this point in the history
…s to pull the official image incorrectly

While kubeadm is buggy (kubernetes/kubernetes#114978) and tries to download the CoreDNS image despite us skipping that addon (kubernetes/kubeadm#2603), we try to use the new official repository already. This fixes `kubeadm join` for new Kubernetes versions and therefore avoids stuck node upgrades. CAPI propagates this value before attempting the node upgrade.
  • Loading branch information
AndiDog committed Jan 11, 2023
1 parent 49e01ec commit df1f32b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Override image repository to `registry.k8s.io` because kubeadm of Kubernetes v1.23.15 tries to pull the official image incorrectly, resulting in failing cluster upgrades, and `k8s.gcr.io` is outdated

## [0.20.4] - 2023-01-05

### Changed
Expand Down
1 change: 1 addition & 0 deletions helm/cluster-aws/templates/_control_plane.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ spec:
name: {{ include "resource.default.name" $ }}-control-plane-{{ include "hash" (dict "data" (include "bastion-awsmachinetemplate-spec" $) "global" .) }}
kubeadmConfigSpec:
clusterConfiguration:
imageRepository: registry.k8s.io {{- /* Temporary so that `kubeadm join` keeps working (https://github.com/giantswarm/roadmap/issues/1669, https://github.com/kubernetes/kubernetes/pull/114978), will later be replaced by Giant Swarm repo via https://github.com/giantswarm/roadmap/issues/1722 */}}
apiServer:
timeoutForControlPlane: 20m
certSANs:
Expand Down

0 comments on commit df1f32b

Please sign in to comment.