Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream coredns version 1.6.5 #8

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Use upstream coredns version 1.6.5 #8

merged 2 commits into from
Nov 20, 2019

Conversation

stone-z
Copy link
Contributor

@stone-z stone-z commented Nov 19, 2019

Update coredns to upstream version 1.6.5 (from 1.6.4) towards https://github.com/giantswarm/giantswarm/issues/7428

No breaking changes listed in release notes

@stone-z stone-z requested a review from a team November 19, 2019 08:32
@stone-z stone-z self-assigned this Nov 19, 2019
@stone-z
Copy link
Contributor Author

stone-z commented Nov 19, 2019

The build failures on this and giantswarm/cluster-autoscaler-app#9 seem suspicious to me -- could there be a lurking CI issue?

@rossf7
Copy link
Contributor

rossf7 commented Nov 19, 2019

@stone-z Looks like the same issue but not sure on the cause. The best logs we have seem to be from tiller Deployment is not ready: kube-system/coredns and are the same in cluster-autoscaler.

https://65-214140051-gh.circle-artifacts.com/0/logs/kind-control-plane/pods/giantswarm_tiller-deploy-7d5b97ff4d-smd7m_5415d1e4-ed9b-43cc-a839-dc9d2fa8046c/tiller/0.log

Can you try re-running the job with SSH and installing kubectl? I think that is the best way to debug it. Otherwise I can try to check it later today.

@stone-z
Copy link
Contributor Author

stone-z commented Nov 19, 2019

Re-ran both jobs and they worked, so I guess it was something on the CircleCI side 🤷‍♂️

Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stone-z Yes might have been a Circle issue. Thanks for reporting and let us know if it comes back.

@stone-z
Copy link
Contributor Author

stone-z commented Nov 20, 2019

Changed this to be a minor version bump since upstream did actually include new features

@stone-z stone-z merged commit c9b94a9 into master Nov 20, 2019
@stone-z stone-z deleted the upstream-1-6-5 branch November 20, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants