Makefile.gen.go: -trimpath for binary size and reproducibility #1045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
-trimpath
flag to the generated Makefile for Go projects.Go's
-trimpath
feature removes the local segments from dependency paths when building. This can reduce binary size by megabytes (for some projects) and generally aids reproducability.This is the help entry for the compiler feature:
The feature should be stable, at least since Go1.18, and a handful of our projects are already using it.
I could find only one known issue when using the feature: LDFLAGS are currently not retained, e.g. not displayed in
go version -m {SOME_BINARY}
. However, this should mostly matter when enablingCGO
, which our Makefiles explicitly disable.EDIT: I stole this trick from here: gohugoio/hugo#12406 (comment)
Checklist