-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intro page overview #2160
Intro page overview #2160
Conversation
I've worked on the english a bit but imo there is more to it than fixing each paragraph. @JosephSalisbury @puja108 please take a look as well and add your ideas how we can create a good intro here. |
Co-authored-by: Timo Derstappen <timo@giantswarm.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's already pretty good now. Some minor comments only.
I was thinking if a graphic or diagram might help visualize this. Either copy the one from CNCF white paper or something from our tech deck. WDYT?
For the platform diagram, I thought it would fit better in the next section "Architecture". WDYT? |
Co-authored-by: Andreas Sommer <andreas@giantswarm.io>
… intro-page-overview
Fine with having it in architecture. I was thinking we could have an abstract one like from the white paper in here and then the architecture one goes deeper into how our real architecture looks like, but not emotional on this, fine to have it just in architecture. |
PTAL |
Merge queue setting changed
Co-authored-by: Andreas Sommer <andreas@giantswarm.io>
Co-authored-by: Andreas Sommer <andreas@giantswarm.io>
|
||
Most of the developers want to deploy an app into production without having to worry too much about security or compliance, but still have good monitoring and deployment options. Our goal is to help the engineers who build and maintain the platform meet developers' expectations without compromising their organizations' security posture. | ||
|
||
Giant Swarm addresses this challenge by providing a flexible base platform. The platform enables technology departments to ensure governance and control over development processes and operations, while providing developers a smooth development cycle. Check out the documentation to learn how we make this possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last sentence feels a bit weird when I'm already inside the documentation. Do you want to point the reader to continue reading this docs page or generally more docs to learn...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than minor language edits lgtm
Co-authored-by: Puja <puja108@gmail.com> Co-authored-by: Cedric Kaufmann <60580186+ced0ps@users.noreply.github.com>
What this PR does / why we need it
Towards https://github.com/giantswarm/giantswarm/issues/30179
Things to check/remember before submitting
If you made content changes
make dev
to render and proofread content changes locally.last_review_date
in the front matter header if you reviewed the entire page.