Use service monitor #562
Merged
Use service monitor #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
use-pod-monitor
branch
from
c3245d9
to
36063f4
Compare
weseven
approved these changes
Mar 30, 2024
QuentinBisson
force-pushed
the
use-pod-monitor
branch
from
99dddf2
to
08743fb
Compare
Gacko
requested changes
Apr 1, 2024
|
I renamed thé PR sorry. I tried to use a podmonitor first but it does not work because this pod is using hostnetwork:true so kyverno is complaining when I add the ports information on thé deployment |
|
But that's probably more an issue because of not using CiliumNetworkPolicies, right? Like, plain NetworkPolicies can not be used for allowing traffic to host network. |
|
Hmm thé issue I had was really related to kyverno policy exceptions but you're free to try a Pod monitor instead :) I don't have the bandwith to do them all "properly", I really just need to get rid of the old annotations asap:) |
Gacko
approved these changes
Apr 1, 2024
| selector: | ||
| {{- include "labels.selector" . | nindent 4 }} | ||
| {{- include "labels.selector" . | nindent 4 }} |
There was a problem hiding this comment.
Suggested change
| {{- include "labels.selector" . | nindent 4 }} | |
| {{- include "labels.selector" . | nindent 4 }} |
Adding the missing/removed newline at EOF.
Gacko
requested changes
Apr 1, 2024
|
Sure :) |
|
It's fixed @Gacko |
Gacko
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configures the operator to be scraped using a service monitor instead of the old scheme