-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align serviceaccount to upstream #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a2335a
to
a687bae
Compare
webwurst
reviewed
Nov 23, 2022
webwurst
suggested changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one typo. Thanks for the detailed testing guide! But I didn't run those myself yet.
Co-authored-by: Tobias Bradtke <webwurst@gmail.com>
webwurst
approved these changes
Nov 24, 2022
mnitchev
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Add upstream helpers for name generation. * Align serviceaccount.yaml to upstream and add respective values * update schemas * Add labels helper * update changelog * update PR in changelog * update labels helper in service account * rework annotation logic * Update references to service account name * Rework annotations * Update CHANGELOG.md Co-authored-by: Tobias Bradtke <webwurst@gmail.com> Co-authored-by: Tobias Bradtke <webwurst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Towards giantswarm/roadmap#411
Checklist
Testing
The instance of external-dns installed as part of Giant Swarm platform releases watches services in the
kube-system
namespace with annotationsgiantswarm.io/external-dns=managed
andexternal-dns.alpha.kubernetes.io/hostname
matching the clusters base domain. (You can find this in the deployments args--domain-filter
value)You can take this example
Service
, apply it to your cluster. Change theexternal-dns.alpha.kubernetes.io/hostname
annotation to match your clusters base domain.then:
Desired change: CREATE test.your.configured.domain.gigantic.io CNAME
https://www.dnstester.net/
)For testing upgrades:
Default app on AWS releases
Default app on Azure releases
Optional app (KVM)