Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align serviceaccount to upstream #207

Merged
merged 11 commits into from
Nov 24, 2022
Merged

Conversation

mcharriere
Copy link
Contributor

@mcharriere mcharriere commented Nov 23, 2022

This PR:

  • Add upstream helpers for name generation.
  • Align serviceaccount.yaml to upstream and add respective values
  • update schemas
  • Add labels helper
  • update changelog

Towards giantswarm/roadmap#411


Checklist

  • Added a CHANGELOG entry

Testing

The instance of external-dns installed as part of Giant Swarm platform releases watches services in the kube-system namespace with annotations giantswarm.io/external-dns=managed and external-dns.alpha.kubernetes.io/hostname matching the clusters base domain. (You can find this in the deployments args --domain-filter value)

You can take this example Service, apply it to your cluster. Change the external-dns.alpha.kubernetes.io/hostname annotation to match your clusters base domain.

then:

  • Check external-dns logs for lines like Desired change: CREATE test.your.configured.domain.gigantic.io CNAME
  • Try to resolve the domain (https://www.dnstester.net/)
apiVersion: v1
kind: Service
metadata:
  annotations:
    external-dns.alpha.kubernetes.io/hostname: test.your.configured.domain.gigantic.io
    external-dns.alpha.kubernetes.io/ttl: "60"
    giantswarm.io/external-dns: managed
  name: test-external-dns
  namespace: kube-system
spec:
  type: ExternalName
  externalName: www.giantswarm.io

For testing upgrades:

  • Create the service and check for creation
  • Upgrade
  • Delete the service and check for deletion

Default app on AWS releases

  • Fresh install works
  • Upgrade works

Default app on Azure releases

  • Fresh install works
  • Upgrade works

Optional app (KVM)

  • Fresh install works
  • Upgrade works

@mcharriere mcharriere requested a review from a team as a code owner November 23, 2022 09:09
@mcharriere mcharriere marked this pull request as draft November 23, 2022 09:21
@mcharriere mcharriere marked this pull request as ready for review November 23, 2022 13:38
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@webwurst webwurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one typo. Thanks for the detailed testing guide! But I didn't run those myself yet.

Co-authored-by: Tobias Bradtke <webwurst@gmail.com>
@mcharriere mcharriere merged commit ef7ee3d into master Nov 24, 2022
@mcharriere mcharriere deleted the upstream-align-serviceaccount branch November 24, 2022 12:24
mnitchev pushed a commit that referenced this pull request Dec 7, 2022
* Add upstream helpers for name generation.

* Align serviceaccount.yaml to upstream and add respective values

* update schemas

* Add labels helper

* update changelog

* update PR in changelog

* update labels helper in service account

* rework annotation logic

* Update references to service account name

* Rework annotations

* Update CHANGELOG.md

Co-authored-by: Tobias Bradtke <webwurst@gmail.com>

Co-authored-by: Tobias Bradtke <webwurst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants