Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In azure, force service principal credentials to be explicitely set. #544

Merged
merged 1 commit into from Jan 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- In azure, force service principal credentials to be explicitely set.

## [5.8.1] - 2022-01-05

## [5.8.0] - 2022-01-05
Expand Down
5 changes: 5 additions & 0 deletions platforms/azure/giantnetes/main.tf
Expand Up @@ -3,6 +3,11 @@ provider "azurerm" {
metadata_host = var.metadata_host
environment = var.environment
skip_provider_registration = true

subscription_id = var.azure_sp_subscriptionid
client_id = var.azure_client_id
client_secret = var.azure_client_secret
tenant_id = var.azure_sp_tenantid
}

data "azurerm_client_config" "current" {}
Expand Down
10 changes: 10 additions & 0 deletions platforms/azure/giantnetes/variables.tf
@@ -1,3 +1,13 @@
variable "azure_client_id" {
type = string
description = "The Azure API client (application) ID"
}

variable "azure_client_secret" {
type = string
description = "The Azure API client (application) secret"
}

variable "github_token" {
type = string
description = "Your personal GITHUB token, used to get access to the private repository 'employees' to get the list of users."
Expand Down