Initial chart implementation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75a93d8.
kopiczko
commented
May 2, 2024
Comment on lines
+9
to
+15
| .PHONY: gen-schma | ||
| gen-schema: $(HELM_SCHEMA) ## Generates schema. | ||
| $(HELM_SCHEMA) -l debug | ||
|
|
||
| .PHONY: unit-test | ||
| unit-test: $(HELM_UNITTEST) ## Run Helm chart unit tests. | ||
| $(HELM_UNITTEST) ./helm/ingress-sla-app |
There was a problem hiding this comment.
It would be good to add CI jobs for that, but I'll add it in a separate PR. This one is big enough without it.
|
Tested on grizzly WC with nginx |
|
|
||
| .PHONY: gen-schma | ||
| gen-schema: $(HELM_SCHEMA) ## Generates schema. | ||
| $(HELM_SCHEMA) -l debug |
There was a problem hiding this comment.
I would be careful here. helm-schema sets additionalProperties: false by default thus blocking possible additional properties. I see you took care of this in your manual schema annotations. And it seems to work how you intended. Just wanted to mention this.
There was a problem hiding this comment.
I tested it on GS WC and it worked fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3229