Support unified cluster-aws app #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Towards giantswarm/roadmap#3119
With cluster-aws v0.76.0 and newer, default apps are deployed with cluster-aws and default-apps-aws app is not deployed anymore.
What is the effect of this change to users?
This PR updates rendering of CAPA templates, so that default-apps-aws is not rendered anymore when cluster-aws version is v0.76.0 and newer.
What does it look like?
(Please add anything that represents the change visually. Screenshots, output, logs, ...)
Any background context you can provide?
giantswarm/roadmap#3119
What is needed from the reviewers?
Check if I missed to update something in kubectl-gs.
Do the docs need to be updated?
Yes, example outputs here https://docs.giantswarm.io/vintage/use-the-api/kubectl-gs/template-cluster/.
Should this change be mentioned in the release notes?
Is this a breaking change?
(Breaking changes are, for example, removal of commnds/flags or substantial changes in the meaning of a flag. If yes, please add the
breaking-changelabel to the PR.)No.