Enable cluster topology for OpenStack by default and update cluster-openstack default version to 0.3.0 #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvddriesch
approved these changes
Jan 21, 2022
rossf7
approved these changes
Jan 21, 2022
kopiczko
reviewed
Jan 25, 2022
cmd/template/cluster/flag.go
Outdated
| @@ -130,7 +130,7 @@ func (f *flag) Init(cmd *cobra.Command) { | |||
|
|
|||
| // OpenStack App only. | |||
| cmd.Flags().StringVar(&f.ClusterApp.ClusterUserConfigMap, flagClusterUserConfigMap, "", "Path to the user values configmap YAML file for Cluster App (OpenStack App CR only).") | |||
| cmd.Flags().StringVar(&f.ClusterApp.ClusterAppVersion, flagClusterAppVersion, "0.1.0", "Cluster App version to be installed. (OpenStack App CR only).") | |||
| cmd.Flags().StringVar(&f.ClusterApp.ClusterAppVersion, flagClusterAppVersion, "0.2.1", "Cluster App version to be installed. (OpenStack App CR only).") | |||
There was a problem hiding this comment.
Suggested change
| cmd.Flags().StringVar(&f.ClusterApp.ClusterAppVersion, flagClusterAppVersion, "0.2.1", "Cluster App version to be installed. (OpenStack App CR only).") | |
| cmd.Flags().StringVar(&f.ClusterApp.ClusterAppVersion, flagClusterAppVersion, "0.2.2", "Cluster App version to be installed. (OpenStack App CR only).") |
There was a problem hiding this comment.
If 0.2.2 is the right version, please update the PR title and description.
There was a problem hiding this comment.
Thanks, yes, I was holding off as I was still deciding what the correct default version should be. I will update the title and description if I change it.
tfussell
changed the title
tfussell
changed the title
|
Made another flag change and updated the version to match with the latest release. |
MarcelMue
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of cluster-openstack is 0.3.0.
In the next
kubectl-gsrelease we will get rid of the old non-cluster topology cluster templating entirely. During the transition it should be the default.