This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Add dockerhub authentication for kubelet #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corest
reviewed
Oct 29, 2020
|
Please note |
tfussell
reviewed
Oct 30, 2020
kopiczko
reviewed
Oct 30, 2020
kopiczko
reviewed
Oct 30, 2020
kopiczko
reviewed
Oct 30, 2020
| labels: | ||
| {{- include "labels.common" . | nindent 4 }} | ||
| data: | ||
| secret.yml: {{ printf "service: {registry: {dockerhubToken: %q}}" .Values.Installation.V1.Secret.Registry.Dockerhub.Token | b64enc | quote }} |
There was a problem hiding this comment.
@corest shouldn't we have something like this here?
secret.yaml: {{ .Values.Installation.V1.Secret.KVMOperator.SecretYaml | b64enc | quote }}
There was a problem hiding this comment.
Talked with @corest. That should be a separate file. To be on par with azure-operator it could be named dockerhub-secret.yaml:
kopiczko
approved these changes
Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/giantswarm#13981
Uses giantswarm/k8scloudconfig#819