Use dns addresses for networkd configuration #635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should do it in general. I was just wondering about the consistency. This here is so consistent and is weird because the kvm-operator
is anyway about the kvm
provider.
It is specific for onprem as we are configuring static networking for qemu node, which is unable to retrieve configuration with ignition and dhcp. Added configuration (https://github.com/giantswarm/installations/blob/master/geckon/draughtsman-configmap-values.yaml#L36) doesn't even exist for cloud providers |
The installations repo is fine. There we need the distinction. Here we are in the |
Ah, got it. Just tried to keep configuration consistent with installation structure. But that is a questionable approach. Dropped |
Required for this giantswarm/k8s-kvm#28