Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Use dns addresses for networkd configuration #635

Merged
merged 9 commits into from Jan 11, 2019
Merged

Use dns addresses for networkd configuration #635

merged 9 commits into from Jan 11, 2019

Conversation

corest
Copy link
Contributor

@corest corest commented Jan 10, 2019

Required for this giantswarm/k8s-kvm#28

@corest corest requested a review from a team January 10, 2019 14:09
Copy link
Contributor

@xh3b4sd xh3b4sd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it in general. I was just wondering about the consistency. This here is so consistent and is weird because the kvm-operator is anyway about the kvm provider.

@corest
Copy link
Contributor Author

corest commented Jan 10, 2019

It is specific for onprem as we are configuring static networking for qemu node, which is unable to retrieve configuration with ignition and dhcp. Added configuration (https://github.com/giantswarm/installations/blob/master/geckon/draughtsman-configmap-values.yaml#L36) doesn't even exist for cloud providers

@corest corest temporarily deployed to geckon January 10, 2019 14:55 Inactive
@xh3b4sd
Copy link
Contributor

xh3b4sd commented Jan 10, 2019

The installations repo is fine. There we need the distinction. Here we are in the kvm-operator. The operator having a flag ala provider.kvm is funny, because it is the kvm-operator. That is what I meant.

@corest
Copy link
Contributor Author

corest commented Jan 10, 2019

Ah, got it. Just tried to keep configuration consistent with installation structure. But that is a questionable approach. Dropped Provider.KVM part

@corest corest temporarily deployed to geckon January 10, 2019 15:21 Inactive
@corest corest temporarily deployed to geckon January 10, 2019 15:33 Inactive
@corest corest merged commit 2ee1437 into master Jan 11, 2019
@corest corest deleted the export_dns branch January 11, 2019 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants