Bump kustomize to v5.0.3 used by our current KC deployment and move back to patchesStrategicMerge because of upstream bug + how we render kustomizations locally
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the upstream kustomize bug of applying patche files with multiple documents + how we locally build kustomizations for development and diff generation on CI.
uvegla
force-pushed
the
fix-shared-makefile
branch
from
8f319b3
to
0622598
Compare
uvegla
changed the title
uvegla
changed the title
kustomize to v5.0.3 used by our current KC deployment and move back to patchesStrategicMerge because of upstream bug + how we render kustomizations locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we render locally or on CI we append vaultless patches to
patchesStrategicMergedirectly into Flux v2 app GS ksutomization. We have to append there because of upstream bug in kustomize that it cannot handle patch files with multiple documents and Flux still uses such a version.For provider specific kustomizations it worked fine, because the vaultless patch was applied later. But if they are in the same file, it seems
patchesStrategicMergeis applied beforepatcheswhich renders an incorrect result.We should keep these - and ones modifying the same resources - in
patchesStrategicMergeuntil Flux bumps to akustomizeversion that has the bug fix.