Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Add relabel config to etcd scrape config #167

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

ericgraf
Copy link
Contributor

@ericgraf ericgraf commented Nov 9, 2020

Add relabel config to etcd scrape config to include the provider label

@ericgraf ericgraf requested a review from a team November 9, 2020 16:03
@ericgraf ericgraf marked this pull request as ready for review November 11, 2020 18:43
@ericgraf
Copy link
Contributor Author

Can confirm that the alerts that were missing the provider label on tc clusters now has the provider label with the changes to prometheus-config-controller.

Copy link
Contributor

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if still needed

Copy link
Contributor

@stone-z stone-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcelMue MarcelMue merged commit 2db71e6 into master Nov 16, 2020
@MarcelMue MarcelMue deleted the TC_add_provider_label_etcd branch November 16, 2020 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants