Remove remote write immutable secret deletion #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nevermind, thunder is not upgraded :( |
|
Thunder is using the latest version |
QuantumEnigmaa
approved these changes
Mar 28, 2023
TheoBrigitte
approved these changes
Mar 28, 2023
marieroque
reviewed
Mar 28, 2023
| return microerror.Mask(err) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
On the first deployment, who create the secret ?
There was a problem hiding this comment.
I'm not sure I follow :D
There was a problem hiding this comment.
We initially created the secret as immutable, this code killed it and creates a non immutable secret. It was deployed everywhere so we do not use immutable secrets anymore
There was a problem hiding this comment.
Ok, but I'm wondering what will happen on a new installation ? the secret will not be created at all, right?
There was a problem hiding this comment.
There was a problem hiding this comment.
My god, I didn't expand the file !!! sorry buddy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.27.0 was released and kicked out all immutable secrets.
Code can now be removed
Checklist
I have:
CHANGELOG.md