update aws.yaml with default disabled autopath #177
Conversation
|
Looks like it failed check because I didn't title the release correctly. That has been fixed but I do not have option via CircleCI UI to rerun job. Is there a way I can do this manually? |
|
@brinker211 it's not title, 1.1.7 release changelog has to be added to https://github.com/giantswarm/releases/blob/master/app/changelog/coredns.yaml |
|
Thanks @sslavic ! That makes sense because I thought it was only referring to https://github.com/giantswarm/coredns-app/blob/master/CHANGELOG.md. I will add to the .yaml you linked. |
|
Change has been made and is awaiting review per above comment. |
|
@brinker211 now you need master changes in this branch, before build can pass. Make sure to also add coredns entry to 9.0.1 release notes https://github.com/giantswarm/releases/blob/aws-901-release/release-notes/aws/v9.0.1.md |
|
Thanks a lot for the help @sslavic 🚀 |
| @@ -15,7 +15,7 @@ | |||
| version: 1.1.4 | |||
| - app: coredns | |||
| componentVersion: 1.6.5 | |||
| version: 1.1.6 | |||
| version: 1.1.7 | |||
There was a problem hiding this comment.
Wait, this needs to be changed to master, not to aws-901-release branch
There was a problem hiding this comment.
For aws-901-release branch, 9.0.1 release definition has to be modified https://github.com/giantswarm/releases/pull/177/files#diff-c09dc41fbe3dfabd5f79fd91555907a9L356
There was a problem hiding this comment.
This is already changed in master - I think this will sort itself out when we merge PRs further. Nothing big to worry about IMO.
|
|
||
| ### coredns v1.6.5 ([Giant Swarm app v1.1.7](https://github.com/giantswarm/coredns-app/blob/master/CHANGELOG.md#v117-2020-03-19)) | ||
|
|
||
| - Changed `autopath` value to disabled by default. |
There was a problem hiding this comment.
Please consider also covering other coredns changes for completeness; release notes covering upgrade from aws 9.0.0 to 9.0.1 should probably mention all changes since (including) coredns-app 1.0.1 https://github.com/giantswarm/coredns-app/blob/master/CHANGELOG.md#v110, because aws 9.0.0 it seems included pre 1.0.0 coredns-app.
You can safely include all changes that 9.1.0 release notes covered for coredns https://github.com/giantswarm/releases/blob/master/release-notes/aws/v9.1.0.md#coredns-v165-giant-swarm-app-v110 + anything newer from coredns-app changelog
| @@ -15,7 +15,7 @@ | |||
| version: 1.1.4 | |||
| - app: coredns | |||
| componentVersion: 1.6.5 | |||
| version: 1.1.6 | |||
| version: 1.1.7 | |||
There was a problem hiding this comment.
This is already changed in master - I think this will sort itself out when we merge PRs further. Nothing big to worry about IMO.
giantswarm/coredns-app#19