Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect JSON Schema features #3

Merged
merged 6 commits into from
Jan 18, 2023
Merged

Collect JSON Schema features #3

merged 6 commits into from
Jan 18, 2023

Conversation

marians
Copy link
Member

@marians marians commented Jan 13, 2023

Towards giantswarm/roadmap#1181

This PR adds analysis and reporting of the features used in the cluster app schemas. In addition to the properties listing, a new tab "Features" is added to show the results.

Preview

image

Details

Each property in each schema is analysed with regard to the JSON Schema capabilities (features) used. For each combination of features, one line item is displayed.

The tabular output shows the following columns:

  1. Feature identifiers
  2. Number of properties found with this feature combination
  3. The exact properties with the given feature combination

The filter function allows to filter the table by feature substrings.

@marians marians self-assigned this Jan 13, 2023
@marians
Copy link
Member Author

marians commented Jan 17, 2023

$ref references are now resolved. no_type should no longer happen.

@marians marians requested a review from gusevda January 17, 2023 13:00
Copy link

@gusevda gusevda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marians marians merged commit 2c634fd into main Jan 18, 2023
@marians marians deleted the collect-features branch January 18, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants