Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cis benchmarks #118

Merged
merged 85 commits into from
Jun 22, 2022
Merged

Add cis benchmarks #118

merged 85 commits into from
Jun 22, 2022

Conversation

fhielpos
Copy link
Member

@fhielpos fhielpos commented Jun 7, 2022

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.
  • (Giant Swarm) If creating a release, bump the version and appVersion in Chart.yaml.

Copy link
Contributor

@stone-z stone-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple early things. Will look again when you're ready (also after you use the new reconciliation pattern if you wanted to do that)

helm/starboard-exporter/Chart.yaml Outdated Show resolved Hide resolved
helm/starboard-exporter/templates/deployment.yaml Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@fhielpos
Copy link
Member Author

I think that everything is done here. I will leave some examples on how the metrics look:

starboard_exporter_ciskubebenchreport_report_summary_count

image

starboard_exporter_ciskubebenchreport_section_summary_count

image

starboard_exporter_ciskubebenchreport_result_info

image

@stone-z all yours. If you think it's okay we can merge it and then update the docs too

@fhielpos fhielpos requested a review from stone-z June 20, 2022 01:39
@fhielpos fhielpos mentioned this pull request Jun 20, 2022
3 tasks
@fhielpos
Copy link
Member Author

Updated the README to add the new feature details.

Copy link
Contributor

@stone-z stone-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mostly small things, open to your preference on them

helm/starboard-exporter/Chart.yaml Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@fhielpos
Copy link
Member Author

Pushing for now so I can test before finally adding the missing ConfigAuditReport metrics to the readme.

@fhielpos fhielpos requested a review from stone-z June 22, 2022 12:38
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@stone-z stone-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 bam

@fhielpos fhielpos merged commit 41bab85 into main Jun 22, 2022
@fhielpos fhielpos deleted the add-cis-benchmarks branch June 22, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants