-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cis benchmarks #118
Add cis benchmarks #118
Conversation
…exporter into add-cis-benchmarks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple early things. Will look again when you're ready (also after you use the new reconciliation pattern if you wanted to do that)
36200b5
to
ccaadc8
Compare
I think that everything is done here. I will leave some examples on how the metrics look: starboard_exporter_ciskubebenchreport_report_summary_countstarboard_exporter_ciskubebenchreport_section_summary_countstarboard_exporter_ciskubebenchreport_result_info@stone-z all yours. If you think it's okay we can merge it and then update the docs too |
Updated the README to add the new feature details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some mostly small things, open to your preference on them
controllers/ciskubebenchreport/ciskubebenchreport_controller.go
Outdated
Show resolved
Hide resolved
controllers/ciskubebenchreport/ciskubebenchreport_controller.go
Outdated
Show resolved
Hide resolved
controllers/ciskubebenchreport/ciskubebenchreport_controller.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Zach Stone <zach@giantswarm.io>
Co-authored-by: Zach Stone <zach@giantswarm.io>
Pushing for now so I can test before finally adding the missing |
controllers/ciskubebenchreport/ciskubebenchreport_controller.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Zach Stone <zach@giantswarm.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 bam
Checklist
values.yaml
andvalues.schema.json
are valid.version
andappVersion
in Chart.yaml.