Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry fix #56

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Registry fix #56

merged 9 commits into from
Jun 19, 2024

Conversation

ssyno
Copy link
Contributor

@ssyno ssyno commented Jun 18, 2024

Towards: giantswarm/roadmap#3493

This PR:

  • changes the way registry is being set in helm templates

Testing

Description on how teleport-kube-agent-app can be tested.

  • fresh install works
    • AWS
    • Azure
    • KVM
  • upgrade from previous version works
    • AWS
    • Azure
    • KVM

Other testing

Description of features to additionally test for teleport-kube-agent-app installations.

  • check reconciliation of existing resources after upgrading
  • X still works after upgrade
  • Y is installed correctly

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.

@ssyno ssyno requested a review from a team as a code owner June 18, 2024 07:05
@ssyno ssyno changed the title registry fix for CN Registry fix Jun 18, 2024
helm/teleport-kube-agent/templates/delete_hook.yaml Outdated Show resolved Hide resolved
helm/teleport-kube-agent/templates/deployment.yaml Outdated Show resolved Hide resolved
helm/teleport-kube-agent/templates/statefulset.yaml Outdated Show resolved Hide resolved
ssyno and others added 3 commits June 18, 2024 18:17
@ssyno ssyno merged commit bbba002 into main Jun 19, 2024
4 checks passed
@ssyno ssyno deleted the Registry-fix branch June 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants