New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Trivy to upstream app version v0.30.4 #57
Conversation
09a37731 feat(helm): allows users to define an existing secret for tokens (#2587) 3e5a0cf2 Type correction bitnami chart (#2415) 92328e2d chore(helm): bump appVersion to latest release (#2397) c87574ae feat(helm): add support for trivy dbRepository (#2345) 04887881 chore: fix spelling errors (#2352) 5e28424d feat(helm): add pod annotations (#2272) 558570f0 feat(helm): support pod annotations (#2265) 0c4ec322 chore: app version 0.27.0 (#2046) 9b7bb4dc chore: app version 26.0 (#2030) 2517f1e4 chore(chart): update Trivy version in HelmChart to 0.25.0 (#1931) 2ce1ec2b feat(helm): make Trivy service name configurable (#1825) 9b48f41a fix(helm): indentation for ServiceAccount annotations (#1795) f781411d chore(helm): remove psp from helm manifest (#1315) 7a924d34 feat(helm): Add support for server token (#1734) 98206c05 feat(helm): Add support for custom labels (#1767) fda8045a chore(helm): bump chart to trivy 0.24.0 (#1762) c40ba89a feat(helm): Parameterise ServiceAccount annotations (#1677) 6a50e4fc chore: Upgrade helm chart version (#1683) 48986053 Add the ability to set dockerhub credentials in the helm chart (#1569) 288df583 chore: helm chart app version 0.22.0 (#1535) e1da3690 refactor(helm): externalize env vars to configMap (#1345) 972b8e54 fix(chart): ingress helm manifest-update trivy image (#1323) 01054834 Add new networking API features to Ingress (#1262) bf7b8bac fix(helm-chart): parametrized ingress host path (#1049) 9f502784 chore: chart with 0.18.3 (#1033) bdd2731a feat: publish helm repository (#888) fd20f815 Added nodeSelector, affinity and tolerations to helm chart (#803) 6a9cc096 Fix env variable for github token (#796) db056dfe Add imagePullSecrets to helm Chart (#789) d76538a6 Add redis cache backend configuration options (#784) 1eda1295 Add gitHubToken to prevent rate limit problems (#769) e23ba19f Add helm chart to install trivy in server mode. (#751) REVERT: d9065a0c Merge commit 'fa04c622e24af8ef730f95e5ad63de92fec5f8f7' as 'upstream-temp' git-subtree-dir: helm/trivy-app/charts/trivy git-subtree-split: 09a377312e5a724296bf224f3a7e8834bae9d9cb
Do we also need to change / remove this? trivy-app/helm/trivy-app/values.yaml Line 13 in e55bb54
|
Any reason why we set the value instead of using the native template?
Wondering if we need it for something GS specific or if we can remove it |
Okay, seems that they added that some versions ago after we were already using the values file. I will remove it and test how it goes without it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bam 👍
Remember not to squash the subtree |
Checklist
values.yaml
andvalues.schema.json
are valid.Important: After this PR is tested and approved, ensure you "Squash and Merge" unless you are updating a subtree. The release automation in use on this repository relies on squashing, but git subtrees will be lost if squashed. This repo allows both, so you may need to change the merge type when merging.