As described in 417592f git outputs to both STDERR and STDOUT in norm…

…al use so we can't use the presence of STDERR output as indication that an error has occurred.

Instead, just log all output with a more verbose log level.

app/controllers/github_hook_controller.rb

@@ -38,13 +38,9 @@ def exec(command)
     output = stdout.readlines.collect(&:strip)
     errors = stderr.readlines.collect(&:strip)
 
-    unless errors.empty?
-      error_message = []
-      error_message << "Error occurred running git"
-      error_message += errors
-      error_message += output
-      logger.error error_message
-    end
+    logger.debug { "GithubHook: Output from git:" }
+    logger.debug { "GithubHook:  * STDOUT: #{output}"}
+    logger.debug { "GithubHook:  * STDERR: #{output}"}
   end
 
 end

test/functional/github_hook_controller_test.rb

@@ -130,21 +130,13 @@ def test_should_not_require_login
     do_post
   end
 
-  def test_exec_should_log_errors_from_git
+  def test_exec_should_log_output_from_git_as_debug
     stdout = mock_descriptor('STDOUT', ["output 1\n", "output 2\n"])
     stderr = mock_descriptor('STDERR', ["error 1\n", "error 2\n"])
     Open3.expects(:popen3).returns(['STDIN', stdout, stderr])
 
-    @controller.logger.expects(:error).with(['Error occurred running git', 'error 1', 'error 2', 'output 1', 'output 2'])
+    @controller.logger.expects(:debug).at_least(4)
     do_post
   end
 
-  def test_exec_should_not_log_errors_if_none_occurred
-    stdout = mock_descriptor('STDOUT', ["output 1\n", "output 2\n"])
-    stderr = mock_descriptor('STDOUT', [])
-    Open3.expects(:popen3).returns(['STDIN', stdout, stderr])
-
-    @controller.logger.expects(:error).never
-    do_post
-  end
 end